Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design ca1 to improve basics aa3 #91

Merged
merged 18 commits into from
Jul 8, 2020

Conversation

schettn
Copy link
Member

@schettn schettn commented Jul 8, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • 🐍

Sorry, something went wrong.

Aichnerc and others added 14 commits July 7, 2020 20:35

Partially verified

This commit is signed with the committer’s verified signature.
spydon’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
The SCSS file extension has been added to auto format for prettier.

Partially verified

This commit is signed with the committer’s verified signature.
spydon’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
The chart points have been removed.

Partially verified

This commit is signed with the committer’s verified signature.
spydon’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Some more color variables have been added to our SCSS config.

Verified

This commit was signed with the committer’s verified signature.
spydon Lukas Klingsbo
The general design of buttons and the profile page has been improved.

Verified

This commit was signed with the committer’s verified signature.
spydon Lukas Klingsbo
The code of the strike and contrib boxes has been greatly improved and does not longer suck. The design of those boxes has been improved. The max height of the chart bars has been reduced.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
There is now a grey chart if there is no language found.

Verified

This commit was signed with the committer’s verified signature.
spydon Lukas Klingsbo
The design of buttons and pinned items has been improved.

Verified

This commit was signed with the committer’s verified signature.
spydon Lukas Klingsbo
The profile button has been moved.

Verified

This commit was signed with the committer’s verified signature.
spydon Lukas Klingsbo
The padding has been adjusted.

Verified

This commit was signed with the committer’s verified signature.
spydon Lukas Klingsbo
The streaks are now marked as days or day.

Verified

This commit was signed with the committer’s verified signature.
spydon Lukas Klingsbo
The slash for owners has been replaced with an @.
None has been replaced with Unknown in the project item.
If there is no owner for a project, the new owner is unknown.
The loading bar styling, which was previously accidentally removed, is now available
again. This will show the loading bar again.
@schettn schettn added the enhancement New feature or request label Jul 8, 2020
@schettn schettn added this to the SNEK Version 0.1.0 milestone Jul 8, 2020
@schettn schettn requested a review from Aichnerc July 8, 2020 18:10
@schettn schettn self-assigned this Jul 8, 2020
@schettn schettn requested a review from Theralun July 8, 2020 18:32
Copy link

@Theralun Theralun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beaut

Some scss stuff has been fixed due to a codacy request.
Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a console.log which could be problematic.

Co-authored-by: Aichner Christian <[email protected]>
@Aichnerc Aichnerc merged commit bfd64b3 into improve-basics-aa3 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants